Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2210693002: Revert of QUIC - Race Cert Verification with host resolution if certs are (Closed)

Created:
4 years, 4 months ago by ramant (doing other things)
Modified:
4 years, 4 months ago
Reviewers:
eroman, mef, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - Race Cert Verification with host resolution if certs are (patchset #10 id:220001 of https://codereview.chromium.org/2120703003/ ) Reason for revert: CQ works ok, but on chromeos build bot the tests fail. Original issue's description: > QUIC - Race Cert Verification with host resolution if certs are > availiable when race_cert_verification network session param is enabled. > > This experiment is not enabled in chromium. > > R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, > TBR=eroman@chromium.org (for net-internals changes) > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/4a42548bd101adfc284fa6e8da6493a2d89f768a > Cr-Commit-Position: refs/heads/master@{#409625} TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/560f3a78c36d47fc345c27c7613ba31e554bee14 Cr-Commit-Position: refs/heads/master@{#409656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -503 lines) Patch
M chrome/browser/resources/net_internals/quic_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.cc View 9 chunks +24 lines, -127 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 7 chunks +0 lines, -18 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 21 chunks +32 lines, -140 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 5 chunks +4 lines, -70 lines 0 comments Download
M net/quic/core/crypto/proof_verifier.h View 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 3 chunks +0 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 5 chunks +2 lines, -37 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ramant (doing other things)
Created Revert of QUIC - Race Cert Verification with host resolution if certs are
4 years, 4 months ago (2016-08-03 23:18:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210693002/1
4 years, 4 months ago (2016-08-03 23:19:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 23:20:03 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:21:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/560f3a78c36d47fc345c27c7613ba31e554bee14
Cr-Commit-Position: refs/heads/master@{#409656}

Powered by Google App Engine
This is Rietveld 408576698