Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2210643002: Consolidate consumeWhitespace calls to one line (Closed)

Created:
4 years, 4 months ago by rwlbuis
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate consumeWhitespace calls to one line We are always calling consumeWhitespace before using prelude, so it is easier to always do this up front. Committed: https://crrev.com/bf18c4ea1428f95d8dcb33d4e9828df7f9a2eeac Cr-Commit-Position: refs/heads/master@{#409969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 9 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rwlbuis
PTAL.
4 years, 4 months ago (2016-08-04 21:25:19 UTC) #3
Timothy Loh
On 2016/08/04 21:25:19, rwlbuis wrote: > PTAL.
4 years, 4 months ago (2016-08-05 00:03:03 UTC) #4
Timothy Loh
On 2016/08/05 00:03:03, Timothy Loh wrote: > On 2016/08/04 21:25:19, rwlbuis wrote: > > PTAL.
4 years, 4 months ago (2016-08-05 00:03:08 UTC) #5
Timothy Loh
oops, touchpad being dodgy and clicking too much.. I guess I did it this way ...
4 years, 4 months ago (2016-08-05 00:04:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210643002/1
4 years, 4 months ago (2016-08-05 00:47:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 02:17:32 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 02:19:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf18c4ea1428f95d8dcb33d4e9828df7f9a2eeac
Cr-Commit-Position: refs/heads/master@{#409969}

Powered by Google App Engine
This is Rietveld 408576698