Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 221063003: Rename test SkUserConfig files. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rename test SkUserConfig files. Since we never want to build with the fake SkUserConfig.h files (they're only there for testing), change their name to SkUserConfig-h.txt. Now the housekeeper will ignore it. Also, update the generated version to match what the housekeeper wanted. It wants my tabs to be 4 spaces, so change my tabs to 4 spaces! NOTRY=true Fixes buildbots. BUG=skia:2365 Committed: http://code.google.com/p/skia/source/detail?r=14013

Patch Set 1 #

Patch Set 2 : Change .h to .txt to skip housekeeping. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -57 lines) Patch
M platform_tools/android/gyp_gen/generate_user_config.py View 1 chunk +5 lines, -5 lines 0 comments Download
D platform_tools/android/tests/expectations/SkUserConfig.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
A + platform_tools/android/tests/expectations/SkUserConfig-h.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M platform_tools/android/tests/generate_user_config_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
D platform_tools/android/tests/inputs/SkUserConfig.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
A + platform_tools/android/tests/inputs/SkUserConfig-h.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scroggo
6 years, 8 months ago (2014-04-01 15:43:52 UTC) #1
epoger
LGTM, but... I wonder if this is telling us that we should change something in ...
6 years, 8 months ago (2014-04-01 17:28:03 UTC) #2
epoger
On 2014/04/01 17:28:03, epoger wrote: > LGTM, but... > > I wonder if this is ...
6 years, 8 months ago (2014-04-01 17:28:49 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-01 17:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/221063003/1
6 years, 8 months ago (2014-04-01 17:36:42 UTC) #5
scroggo
On 2014/04/01 17:36:42, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 8 months ago (2014-04-01 18:21:37 UTC) #6
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-01 18:21:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/221063003/20001
6 years, 8 months ago (2014-04-01 18:21:48 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 19:03:03 UTC) #9
Message was sent while issue was closed.
Change committed as 14013

Powered by Google App Engine
This is Rietveld 408576698