Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2210613002: Add binaries that were missing from the GN DrM build target. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add binaries that were missing from the GN DrM build target. I missed three when I added the target yesterday :(. TBR=groby@chromium.org BUG=633693 Committed: https://crrev.com/9b8bb5421b65b1767d852b02be69001eccfe1818 Cr-Commit-Position: refs/heads/master@{#409664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 4 months ago (2016-08-03 21:52:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210613002/1
4 years, 4 months ago (2016-08-03 21:53:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 23:39:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b8bb5421b65b1767d852b02be69001eccfe1818 Cr-Commit-Position: refs/heads/master@{#409664}
4 years, 4 months ago (2016-08-03 23:41:20 UTC) #6
groby-ooo-7-16
4 years, 4 months ago (2016-08-05 21:25:42 UTC) #7
Message was sent while issue was closed.
On 2016/08/03 23:41:20, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9b8bb5421b65b1767d852b02be69001eccfe1818
> Cr-Commit-Position: refs/heads/master@{#409664}

LGTM ex post facto

Powered by Google App Engine
This is Rietveld 408576698