chrome/browser/resources/settings/printing_page/printing_page.html - Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/printing_page.html

Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | chrome/browser/resources/settings/privacy_page/privacy_page.html » ('j') | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/printing_page.html

diff --git a/chrome/browser/resources/settings/printing_page/printing_page.html b/chrome/browser/resources/settings/printing_page/printing_page.html

index bd854609a8b1173b10e5e1caf7ff2aa43e271d3e..71f48b44ebab080dff654e4b1554e065e66d8eb2 100644

--- a/chrome/browser/resources/settings/printing_page/printing_page.html

+++ b/chrome/browser/resources/settings/printing_page/printing_page.html

@@ -32,13 +32,17 @@

</neon-animatable>

- <settings-subpage page-title="$i18n{cupsPrintersTitle}">

+ <settings-subpage

+ associated-control="[[$$('#cupsPrinters')]]"

+ page-title="$i18n{cupsPrintersTitle}">

<settings-cups-printers></settings-cups-printers>

</settings-subpage>

</template>

</if>

- <settings-subpage page-title="$i18n{cloudPrintersTitle}">

+ <settings-subpage

+ associated-control="[[$$('#cloudPrinters')]]"

+ page-title="$i18n{cloudPrintersTitle}">

<settings-cloud-printers prefs="{{prefs}}">

</settings-cloud-printers>

</settings-subpage>