chrome/browser/resources/settings/appearance_page/appearance_page.html - Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/device_page/device_page.html » ('j') | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/appearance_page/appearance_page.html

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html

index 195d357878e4dfb58bd38bd6fd51d64eabf83f58..861bf8fda92d8763f36e684be9f7f6591934121e 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html

@@ -106,7 +106,8 @@

menu-options="[[fontSizeOptions_]]" no-label-float>

</settings-dropdown-menu>

</div>

- <div class="settings-box two-line single-column"

+ <div id="customize-fonts-subpage-trigger"

+ class="settings-box two-line single-column"

on-tap="onCustomizeFontsTap_" actionable>

<div>$i18n{customizeFonts}</div>

<div class="secondary">$i18n{chooseFontsAndEncoding}</div>

@@ -120,7 +121,9 @@

</div>

</neon-animatable>

- <settings-subpage page-title="$i18n{customizeFonts}">

+ <settings-subpage

+ associated-control="[[$$('#customize-fonts-subpage-trigger')]]"

+ page-title="$i18n{customizeFonts}">

<settings-appearance-fonts-page prefs="{{prefs}}">

</settings-appearance-fonts-page>

</settings-subpage>