Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.js

Issue 2210583002: MD Settings: Associate suppages with the controls that trigger them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-subpage' shows a subpage beneath a subheader. The header contains 7 * 'settings-subpage' shows a subpage beneath a subheader. The header contains
8 * the subpage title and a back icon. The back icon fires an event which 8 * the subpage title and a back icon. The back icon fires an event which
9 * is caught by settings-animated-pages, so it requires no separate handling. 9 * is caught by settings-animated-pages, so it requires no separate handling.
10 */ 10 */
(...skipping 11 matching lines...) Expand all
22 pageTitle: String, 22 pageTitle: String,
23 23
24 /** Setting a |searchLabel| will enable search. */ 24 /** Setting a |searchLabel| will enable search. */
25 searchLabel: String, 25 searchLabel: String,
26 26
27 searchTerm: { 27 searchTerm: {
28 type: String, 28 type: String,
29 notify: true, 29 notify: true,
30 value: '', 30 value: '',
31 }, 31 },
32
33 /** @type {?HTMLElement} */
34 associatedControl: Object,
Dan Beam 2016/08/04 23:57:42 should this be value: null by default, then?
dpapad 2016/08/05 00:03:27 Done.
35
36 /**
37 * Indicates whether an associated control (an element that triggers the
38 * subpage) is not registered for this page. Used by the searching algorithm
39 * to show search bubbles.
40 */
41 noAssociatedControl: {
42 type: Boolean,
43 value: false,
44 },
32 }, 45 },
33 46
34 /** @private */ 47 /** @private */
35 onTapBack_: function() { 48 onTapBack_: function() {
36 // Event is caught by settings-animated-pages. 49 // Event is caught by settings-animated-pages.
37 this.fire('subpage-back'); 50 this.fire('subpage-back');
38 }, 51 },
39 52
40 /** @private */ 53 /** @private */
41 onSearchChanged_: function(e) { 54 onSearchChanged_: function(e) {
42 this.searchTerm = e.detail; 55 this.searchTerm = e.detail;
43 }, 56 },
44 }); 57 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698