Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Issue 2210543002: Fixup class name spelling (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@cr603490
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fixup class name spelling Fix CXFA_FMIdentifierExpressionn to remove the duplicate n. Committed: https://pdfium.googlesource.com/pdfium/+/ca27127240fbca2184f1c576b15b5212d5b314e6

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M xfa/fxfa/fm2js/xfa_fmparse.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-03 14:58:50 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-03 16:35:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210543002/1
4 years, 4 months ago (2016-08-03 17:21:48 UTC) #9
commit-bot: I haz the power
Failed to apply patch for xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-08-03 17:22:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210543002/20001
4 years, 4 months ago (2016-08-03 17:27:18 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:48:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ca27127240fbca2184f1c576b15b5212d5b3...

Powered by Google App Engine
This is Rietveld 408576698