Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2210533003: Disable system_health.memory_mobile on Android One. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 @classmethod 48 @classmethod
49 def Name(cls): 49 def Name(cls):
50 return 'system_health.memory_%s' % cls.PLATFORM 50 return 'system_health.memory_%s' % cls.PLATFORM
51 51
52 @classmethod 52 @classmethod
53 def ValueCanBeAddedPredicate(cls, value, is_first_result): 53 def ValueCanBeAddedPredicate(cls, value, is_first_result):
54 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard 54 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
55 # is able to cope with the data load generated by TBMv2 metrics. 55 # is able to cope with the data load generated by TBMv2 metrics.
56 return not _IGNORED_STATS_RE.search(value.name) 56 return not _IGNORED_STATS_RE.search(value.name)
57 57
58 @classmethod
59 def ShouldDisable(cls, possible_browser):
60 return cls.IsSvelte(possible_browser) # http://crbug.com/634112
61
58 62
59 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark): 63 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
60 """Desktop Chrome Memory System Health Benchmark.""" 64 """Desktop Chrome Memory System Health Benchmark."""
61 PLATFORM = 'desktop' 65 PLATFORM = 'desktop'
62 66
63 @classmethod 67 @classmethod
64 def ShouldDisable(cls, possible_browser): 68 def ShouldDisable(cls, possible_browser):
65 # http://crbug.com/624355 (reference builds). 69 # http://crbug.com/624355 (reference builds).
66 return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or 70 return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or
67 possible_browser.browser_type == 'reference') 71 possible_browser.browser_type == 'reference')
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 options.config.atrace_config.app_name = 'org.chromium.webview_shell' 104 options.config.atrace_config.app_name = 'org.chromium.webview_shell'
101 return options 105 return options
102 106
103 @classmethod 107 @classmethod
104 def ShouldTearDownStateAfterEachStoryRun(cls): 108 def ShouldTearDownStateAfterEachStoryRun(cls):
105 return True 109 return True
106 110
107 @classmethod 111 @classmethod
108 def Name(cls): 112 def Name(cls):
109 return 'system_health.webview_startup' 113 return 'system_health.webview_startup'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698