[modules] Mark namespace variables as kCreatedInitialized.

src/ast/ast.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_AST_H_
 #define V8_AST_AST_H_
 
 #include "src/ast/ast-value-factory.h"
 #include "src/ast/modules.h"
 #include "src/ast/variables.h"
@@ skipping 509 matching lines @@
 
   // Nested scope from which the declaration originated.
   Scope* scope_;
 };
 
 
 class VariableDeclaration final : public Declaration {
  public:
   DECLARE_NODE_TYPE(VariableDeclaration)
 
-  InitializationFlag initialization() const {
-    return mode() == VAR ? kCreatedInitialized : kNeedsInitialization;
-  }
+  InitializationFlag initialization() const { return initialization_; }

[adamk, 2016/08/03 17:55:48]

Strangely this method is only used inside the parser, for communication between
the things that create declarations and the Parser::Declare method. Perhaps it
should just be an argument to Parser::Declare?

 
  protected:
   VariableDeclaration(Zone* zone, VariableProxy* proxy, VariableMode mode,
-                      Scope* scope, int pos)
-      : Declaration(zone, proxy, mode, scope, pos, kVariableDeclaration) {}
+                      Scope* scope, InitializationFlag initialization, int pos)
+      : Declaration(zone, proxy, mode, scope, pos, kVariableDeclaration),
+        initialization_(initialization) {}
+
+ private:
+  InitializationFlag initialization_;
 };
 
 
 class FunctionDeclaration final : public Declaration {
  public:
   DECLARE_NODE_TYPE(FunctionDeclaration)
 
   FunctionLiteral* fun() const { return fun_; }
   void set_fun(FunctionLiteral* f) { fun_ = f; }
   InitializationFlag initialization() const { return kCreatedInitialized; }
@@ skipping 2504 matching lines @@
 
   AstValueFactory* ast_value_factory() const { return ast_value_factory_; }
   void set_ast_value_factory(AstValueFactory* ast_value_factory) {
     ast_value_factory_ = ast_value_factory;
     zone_ = ast_value_factory->zone();
   }
 
   VariableDeclaration* NewVariableDeclaration(VariableProxy* proxy,
                                               VariableMode mode, Scope* scope,
                                               int pos) {
-    return new (zone_) VariableDeclaration(zone_, proxy, mode, scope, pos);
+    return NewVariableDeclaration(
+        proxy, mode, scope,
+        mode == VAR ? kCreatedInitialized : kNeedsInitialization, pos);
+  }
+
+  VariableDeclaration* NewVariableDeclaration(VariableProxy* proxy,
+                                              VariableMode mode, Scope* scope,
+                                              InitializationFlag init,
+                                              int pos) {
+    return new (zone_)
+        VariableDeclaration(zone_, proxy, mode, scope, init, pos);
   }
 
   FunctionDeclaration* NewFunctionDeclaration(VariableProxy* proxy,
                                               VariableMode mode,
                                               FunctionLiteral* fun,
                                               Scope* scope,
                                               int pos) {
     return new (zone_) FunctionDeclaration(zone_, proxy, mode, fun, scope, pos);
   }
 
@@ skipping 446 matching lines @@
                                     : NULL;                                   \
   }
 AST_NODE_LIST(DECLARE_NODE_FUNCTIONS)
 #undef DECLARE_NODE_FUNCTIONS
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_AST_AST_H_