[modules] Mark namespace variables as kCreatedInitialized.

[modules] Mark namespace variables as kCreatedInitialized.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/a126da43692337a09d3cfb0da2a9717b9ca4cef7
Cr-Commit-Position: refs/heads/master@{#38430}

[neis, 2016-08-03 14:48:14]

https://codereview.chromium.org/2210533002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2210533002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1951: }
I will try to reuse this function in other places, perhaps in a slightly
generalized form.  I think these three steps are very common.

[adamk, 2016-08-03 17:55:48]

This lgtm, but I wonder if the Declaration::initialization() method is even
needed. It's only used by the parser: backend(s) inspect the Variable when they
want to know more about this.

https://codereview.chromium.org/2210533002/diff/1/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2210533002/diff/1/src/ast/ast.h#newcode530
src/ast/ast.h:530: InitializationFlag initialization() const { return
initialization_; }
Strangely this method is only used inside the parser, for communication between
the things that create declarations and the Parser::Declare method. Perhaps it
should just be an argument to Parser::Declare?

[neis, 2016-08-08 10:01:22]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-08 10:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2210533002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-08 10:01:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 10:23:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 10:27:23]

Description was changed from

==========
[modules] Mark namespace variables as kCreatedInitialized.

R=adamk@chromium.org
BUG=
==========

to

==========
[modules] Mark namespace variables as kCreatedInitialized.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/a126da43692337a09d3cfb0da2a9717b9ca4cef7
Cr-Commit-Position: refs/heads/master@{#38430}
==========

[commit-bot: I haz the power, 2016-08-08 10:27:24]

Patchset 2 (id:??) landed as
https://crrev.com/a126da43692337a09d3cfb0da2a9717b9ca4cef7
Cr-Commit-Position: refs/heads/master@{#38430}