runtime/bin/socket_win.cc - Issue 2210523002: Revert "Better error-message when bind fails."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_win.cc

Issue 2210523002: Revert "Better error-message when bind fails." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket_win.cc

diff --git a/runtime/bin/socket_win.cc b/runtime/bin/socket_win.cc

index f76f764c7c4835789c8fda0024d216c3b34778b7..e3d366da53bf8a83501d60f6d9b31b06e6748421 100644

--- a/runtime/bin/socket_win.cc

+++ b/runtime/bin/socket_win.cc

@@ -250,12 +250,6 @@ intptr_t Socket::CreateBindConnect(const RawAddr& addr,

}

-bool Socket::IsBindError(intptr_t error_number) {

- return error_number == WSAEADDRINUSE || error_number == WSAEADDRNOTAVAIL ||

- error_number == WSAEINVAL;

void Socket::GetError(intptr_t fd, OSError* os_error) {

Handle* handle = reinterpret_cast<Handle*>(fd);

os_error->SetCodeAndMessage(OSError::kSystem, handle->last_error());