Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 2210513002: [Strings] Removed unused settings reset strings. (Closed)

Created:
4 years, 4 months ago by Mathieu
Modified:
4 years, 4 months ago
Reviewers:
engedy, robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Strings] Removed unused settings reset strings. BUG=None Committed: https://crrev.com/afb1f13f243604d7d6c29c32e87b49dc5a0467d3 Cr-Commit-Position: refs/heads/master@{#409513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Mathieu
Balazs, please have a look?
4 years, 4 months ago (2016-08-03 13:36:49 UTC) #5
engedy
LGTM, provided you check with robertshield@ that he is not planning to use this either. ...
4 years, 4 months ago (2016-08-03 14:47:16 UTC) #8
robertshield
lgtm
4 years, 4 months ago (2016-08-03 14:53:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210513002/1
4 years, 4 months ago (2016-08-03 14:54:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 14:57:36 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 14:59:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afb1f13f243604d7d6c29c32e87b49dc5a0467d3
Cr-Commit-Position: refs/heads/master@{#409513}

Powered by Google App Engine
This is Rietveld 408576698