Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2210483002: Check that heap collection backing reallocation happens on the same heap (Closed)

Created:
4 years, 4 months ago by keishi
Modified:
4 years, 4 months ago
Reviewers:
haraken, oilpan-reviews
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, Mads Ager (chromium), zoltan1, blink-reviews-layout_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that heap collection backing reallocation happens on the same heap BUG=591606 Committed: https://crrev.com/90126696891433f36c73c61905f238ced7777500 Cr-Commit-Position: refs/heads/master@{#412500}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapAllocator.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
keishi
4 years, 4 months ago (2016-08-16 13:10:03 UTC) #6
haraken
LGTM
4 years, 4 months ago (2016-08-16 13:36:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210483002/20001
4 years, 4 months ago (2016-08-17 08:04:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/53359)
4 years, 4 months ago (2016-08-17 08:06:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210483002/20001
4 years, 4 months ago (2016-08-17 08:38:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 11:51:21 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 11:52:43 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90126696891433f36c73c61905f238ced7777500
Cr-Commit-Position: refs/heads/master@{#412500}

Powered by Google App Engine
This is Rietveld 408576698