third_party/WebKit/Source/core/fetch/DocumentResource.cpp - Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/DocumentResource.cpp

Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/cache/xmlhttprequest-onload-event-for-successful-revalidation.html ('K') | « third_party/WebKit/Source/core/fetch/DocumentResource.h ('k') | third_party/WebKit/Source/core/fetch/FontResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/DocumentResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/DocumentResource.cpp b/third_party/WebKit/Source/core/fetch/DocumentResource.cpp

index f6b8b51e664bc1c2c67dc98fb619f533dc3d4a75..bdfdfeab1a838cd7e35c3807c0d355d5c082e733 100644

--- a/third_party/WebKit/Source/core/fetch/DocumentResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/DocumentResource.cpp

@@ -54,14 +54,14 @@ DEFINE_TRACE(DocumentResource)

Resource::trace(visitor);

}

-void DocumentResource::checkNotify()

+void DocumentResource::checkNotify(MarkFinishedOption markFinishedOption)

{

if (m_data && mimeTypeAllowed()) {

// We don't need to create a new frame because the new document belongs to the parent UseElement.

m_document = createDocument(response().url());

m_document->setContent(decodedText());

}

- Resource::checkNotify();

+ Resource::checkNotify(markFinishedOption);

}

bool DocumentResource::mimeTypeAllowed() const