Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
index 099ab741690132d2c62c5260dcc973d63f2f30fe..00d4ddf795ea0aa2d0ddfebcaaa208c300914b02 100644
--- a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
@@ -99,15 +99,18 @@ const String CSSStyleSheetResource::sheetText(MIMETypeCheck mimeTypeCheck) const
return decodedText();
}
-void CSSStyleSheetResource::checkNotify()
+void CSSStyleSheetResource::checkNotify(MarkFinishedOption markFinishedOption)
{
// Decode the data to find out the encoding and keep the sheet text around during checkNotify()
if (m_data)
m_decodedSheetText = decodedText();
ResourceClientWalker<StyleSheetResourceClient> w(clients());
- while (StyleSheetResourceClient* c = w.next())
+ while (StyleSheetResourceClient* c = w.next()) {
+ if (markFinishedOption == MarkFinishedOption::ShouldMarkFinished)
+ markClientFinished(c);
c->setCSSStyleSheet(resourceRequest().url(), response().url(), encoding(), this);
+ }
// Clear the decoded text as it is unlikely to be needed immediately again and is cheap to regenerate.
m_decodedSheetText = String();
}

Powered by Google App Engine
This is Rietveld 408576698