third_party/WebKit/Source/core/fetch/Resource.h - Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reflect comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/cache/xmlhttprequest-onload-event-for-failed-revalidation.html ('K') | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index 471249d76b8b0c592d62abc1705f79024817585b..22e1039e40225469d9f7925a165418f15cbea0a0 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -249,6 +249,13 @@ protected:

virtual void checkNotify();

+ enum class MarkFinishedOption {

+ ShouldMarkFinished,

+ DoNotMarkFinished

+ };

+ void notifyClientsInternal(MarkFinishedOption);

+ void markClientFinished(ResourceClient*);

virtual void destroyDecodedDataForFailedRevalidation() { }

void setEncodedSize(size_t);

@@ -283,8 +290,6 @@ protected:

virtual bool isSafeToUnlock() const { return false; }

virtual void destroyDecodedDataIfPossible() { }

- virtual void markClientsAndObserversFinished();

// Returns the memory dump name used for tracing. See Resource::onMemoryDump.

String getMemoryDumpName() const;