Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wrap by 80 cols and Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 void createImage(); 156 void createImage();
157 void updateImage(bool allDataReceived); 157 void updateImage(bool allDataReceived);
158 void updateImageAndClearBuffer(); 158 void updateImageAndClearBuffer();
159 void clearImage(); 159 void clearImage();
160 // If not null, changeRect is the changed part of the image. 160 // If not null, changeRect is the changed part of the image.
161 void notifyObservers(const IntRect* changeRect = nullptr); 161 void notifyObservers(const IntRect* changeRect = nullptr);
162 162
163 void ensureImage(); 163 void ensureImage();
164 164
165 void checkNotify() override; 165 void checkNotify() override;
166 void markClientsAndObserversFinished() override; 166 void notifyObserversInternal(MarkFinishedOption);
167 void markObserverFinished(ImageResourceObserver*);
167 168
168 void doResetAnimation(); 169 void doResetAnimation();
169 170
170 bool isSafeToUnlock() const override; 171 bool isSafeToUnlock() const override;
171 void destroyDecodedDataIfPossible() override; 172 void destroyDecodedDataIfPossible() override;
172 void destroyDecodedDataForFailedRevalidation() override; 173 void destroyDecodedDataForFailedRevalidation() override;
173 174
174 float m_devicePixelRatioHeaderValue; 175 float m_devicePixelRatioHeaderValue;
175 176
176 Member<MultipartImageResourceParser> m_multipartParser; 177 Member<MultipartImageResourceParser> m_multipartParser;
177 RefPtr<blink::Image> m_image; 178 RefPtr<blink::Image> m_image;
178 MultipartParsingState m_multipartParsingState = MultipartParsingState::Waiti ngForFirstPart; 179 MultipartParsingState m_multipartParsingState = MultipartParsingState::Waiti ngForFirstPart;
179 bool m_hasDevicePixelRatioHeaderValue; 180 bool m_hasDevicePixelRatioHeaderValue;
180 HashCountedSet<ImageResourceObserver*> m_observers; 181 HashCountedSet<ImageResourceObserver*> m_observers;
181 HashCountedSet<ImageResourceObserver*> m_finishedObservers; 182 HashCountedSet<ImageResourceObserver*> m_finishedObservers;
182 }; 183 };
183 184
184 DEFINE_RESOURCE_TYPE_CASTS(Image); 185 DEFINE_RESOURCE_TYPE_CASTS(Image);
185 186
186 } // namespace blink 187 } // namespace blink
187 188
188 #endif 189 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698