third_party/WebKit/LayoutTests/http/tests/cache/xmlhttprequest-onload-event-for-failed-revalidation.html - Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/cache/xmlhttprequest-onload-event-for-failed-revalidation.html

Issue 2210473002: Mark ResourceClient/ImageResourceObserver finished just before notifying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reflect comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/cache/resources/etag-200.php ('k') | third_party/WebKit/LayoutTests/http/tests/cache/xmlhttprequest-onload-event-for-successful-revalidation.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script>

	6 async_test(function(t) {

	7 const url = 'resources/etag-200.php?' + Math.floor(100000000 * Math.random()) ;
	yhirano 2016/08/10 06:13:50 nit optional; If you want to wrap lines in 80 cols nit optional; If you want to wrap lines in 80 cols (I think yo do because of L23-L24), this line should be fixed. hiroshige 2016/08/23 10:35:07 Done. Show quoted text On 2016/08/10 06:13:50, yhirano wrote: > nit optional; If you want to wrap lines in 80 cols (I think yo do because of > L23-L24), this line should be fixed. Done.
	8 const xhr1 = new XMLHttpRequest();

	9 xhr1.onload = function() {

	10 assert_equals(xhr1.status, 200);

	11

	12 const xhr2 = new XMLHttpRequest();

	13 xhr2.onload = function() {

	14 assert_equals(xhr2.status, 200);

	15 t.done();

	16 };

	17 xhr2.open("GET", url, true);

	18 xhr2.send();

	19 };

	20

	21 xhr1.open("GET", url, true);

	22 xhr1.send();

	23 }, "onload event must be invoked for failed revalidation when XHR's " +

	24 "onload handler initiates a new XHR to the same URL.");

	25 </script>

	26 </head>

OLD	NEW