Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2210463002: Port the second Factory::NewError variant (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port the second Factory::NewError variant BUG= Committed: https://crrev.com/14061979f79d38a98c765541d97a63044d3d11a2 Cr-Commit-Position: refs/heads/master@{#38296}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/factory.cc View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
4 years, 4 months ago (2016-08-03 08:50:50 UTC) #6
Yang
lgtm.
4 years, 4 months ago (2016-08-03 09:18:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210463002/20001
4 years, 4 months ago (2016-08-03 13:03:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 13:56:53 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:57:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14061979f79d38a98c765541d97a63044d3d11a2
Cr-Commit-Position: refs/heads/master@{#38296}

Powered by Google App Engine
This is Rietveld 408576698