webrtc/modules/desktop_capture/screen_drawer.cc - Issue 2210443002: [WebRTC] Implement Windows ScreenDrawer to test ScreenCapturer*

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/desktop_capture/screen_drawer.cc

Issue 2210443002: [WebRTC] Implement Windows ScreenDrawer to test ScreenCapturer* (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Implement ScreenDrawer for X11 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/desktop_capture/screen_drawer.h ('K') | « webrtc/modules/desktop_capture/screen_drawer.h ('k') | webrtc/modules/desktop_capture/screen_drawer_linux.h » ('j') | webrtc/modules/desktop_capture/screen_drawer_linux.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #include "webrtc/modules/audio_coding/neteq/packet.h"	11 #include "webrtc/modules/desktop_capture/screen_drawer.h"

12	12

13 namespace webrtc {	13 namespace webrtc {

14	14

15 Packet::Packet() = default;	15 ScreenDrawer::ScreenDrawer() = default;

16	16 ScreenDrawer::~ScreenDrawer() = default;
	Sergey Ulanov 2016/08/09 17:43:00 these can be in the header, since it's an abstract these can be in the header, since it's an abstract interface. Also please use {} instead of =default; It's more readable and makes no difference for this class. Hzj_jie 2016/08/11 18:42:03 Done. Show quoted text On 2016/08/09 17:43:00, Sergey Ulanov wrote: > these can be in the header, since it's an abstract interface. Also please use {} > instead of =default; It's more readable and makes no difference for this class. Done.
17 Packet::~Packet() = default;

18	17

19 } // namespace webrtc	18 } // namespace webrtc

OLD	NEW