Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2210383003: Revert of Clang update.py: enable debug info for ToT builds (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Reid Kleckner, hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clang update.py: enable debug info for ToT builds (patchset #1 id:1 of https://codereview.chromium.org/2213743002/ ) Reason for revert: Speculative. clang binaries started failing without any message (e.g. https://build.chromium.org/p/chromium.fyi/builders/CrWinAsanCov/builds/2740/steps/compile/logs/stdio). I don't see how this change could cause that, but it's in the blame list of each of the win bots where this fails, non-win bots are fine, and this is the only thing I see that is vaguely related. Original issue's description: > Clang update.py: enable debug info for ToT builds > > This should give us better stack traces when Clang crashes, which is > useful when doing ToT builds, whose purpose is to catch Clang regressions > early. > > BUG=none > > Committed: https://crrev.com/c58e45deb3bbb26184bb6b034b785fbfec89668e > Cr-Commit-Position: refs/heads/master@{#409802} TBR=rnk@chromium.org,hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/949ce560edea778357f6df5441b68d66144048f8 Cr-Commit-Position: refs/heads/master@{#409893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M tools/clang/scripts/update.py View 2 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
Created Revert of Clang update.py: enable debug info for ToT builds
4 years, 4 months ago (2016-08-04 20:43:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210383003/1
4 years, 4 months ago (2016-08-04 20:43:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 20:44:26 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/949ce560edea778357f6df5441b68d66144048f8 Cr-Commit-Position: refs/heads/master@{#409893}
4 years, 4 months ago (2016-08-04 20:45:56 UTC) #6
Nico
4 years, 4 months ago (2016-08-04 22:01:58 UTC) #7
Message was sent while issue was closed.
Compiles work again now. Begin of breakage and end of breakage correlate exactly
with landing and reverting this CL, so it's likely it is indeed the cause. No
idea why though.

Powered by Google App Engine
This is Rietveld 408576698