Implement Vulkan Resolve.

Implement Vulkan Resolve.

First step to getting msaa running on vulkan

BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210383002

Committed: https://skia.googlesource.com/skia/+/52ad25151a1c7d1ac3872971f56adf15200c437e

[egdaniel, 2016-08-04 17:43:39]

Description was changed from

==========
Implement Vulkan Resolve.

First step to getting msaa running on vulkan

BUG=skia:5127
==========

to

==========
Implement Vulkan Resolve.

First step to getting msaa running on vulkan

BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210383002
==========

[egdaniel, 2016-08-04 17:47:58]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com, robertphillips@google.com

[jvanverth1, 2016-08-04 19:00:48]

https://codereview.chromium.org/2210383002/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2210383002/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:582: GR_VK_CALL(gpu->vkInterface(),
CmdResolveImage(fCmdBuffer,
Do we need to transition the image layouts to anything special before doing
this? Or will that be done outside of this method?

[egdaniel, 2016-08-04 19:16:17]

https://codereview.chromium.org/2210383002/diff/20001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2210383002/diff/20001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:582: GR_VK_CALL(gpu->vkInterface(),
CmdResolveImage(fCmdBuffer,
On 2016/08/04 19:00:48, jvanverth1 wrote:
> Do we need to transition the image layouts to anything special before doing
> this? Or will that be done outside of this method?

ahh yes good catch. layouts changed in GrVkGpu::onResolveRT

[jvanverth1, 2016-08-04 19:25:47]

lgtm

[egdaniel, 2016-08-04 19:26:48]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-08-04 19:26:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 19:50:03]

Description was changed from

==========
Implement Vulkan Resolve.

First step to getting msaa running on vulkan

BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210383002
==========

to

==========
Implement Vulkan Resolve.

First step to getting msaa running on vulkan

BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210383002

Committed:
https://skia.googlesource.com/skia/+/52ad25151a1c7d1ac3872971f56adf15200c437e
==========

[commit-bot: I haz the power, 2016-08-04 19:50:04]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/52ad25151a1c7d1ac3872971f56adf15200c437e