|
[headless] Do not give ownership of HeadlessBrowserContext to user.
Public API changes:
- HeadlessBrowserContext::Builder::Build now returns raw pointer instead of unique_ptr. Lifetime of HeadlessBrowserContexts is managed by the browser now.
- Added HeadlessBrowserContext::Close method to give used the option to delete HeadlessBrowserContext.
- Added HeadlessBrowserContext::Id and HeadlessBrowser::GetBrowserContextForId methods for BrowserContext identification.
Internal changes:
- HeadlessWebContents are owned by HeadlessBrowserContext.
- HeadlessBrowserContexts are now owned by HeadlessBrowser.
- Instead of browser having a weak pointer to HeadlessDevToolsManagerDelegate opposite happens: HeadlessDevToolsManagerDelegate weakly references HeadlessBrowser.
BUG= 546953
Committed: https://crrev.com/bf875c9ce90acb08c5be5f26b1df53085013e0e2
Cr-Commit-Position: refs/heads/master@{#409816}
Total comments: 6
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+374 lines, -233 lines) |
Patch |
|
M |
headless/app/headless_shell.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_browser_context_impl.h
|
View
|
1
2
3
|
2 chunks |
+22 lines, -9 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_browser_context_impl.cc
|
View
|
1
2
3
|
8 chunks |
+73 lines, -25 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_browser_impl.h
|
View
|
1
2
3
|
3 chunks |
+19 lines, -14 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_browser_impl.cc
|
View
|
1
2
3
|
3 chunks |
+54 lines, -51 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_content_browser_client.cc
|
View
|
1
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_devtools_manager_delegate.h
|
View
|
1
2
|
3 chunks |
+4 lines, -12 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_devtools_manager_delegate.cc
|
View
|
1
2
3
|
9 chunks |
+25 lines, -40 lines |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_web_contents_impl.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
headless/lib/browser/headless_web_contents_impl.cc
|
View
|
1
2
3
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
headless/lib/embedder_mojo_browsertest.cc
|
View
|
1
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
headless/lib/headless_browser_browsertest.cc
|
View
|
|
12 chunks |
+89 lines, -34 lines |
0 comments
|
Download
|
|
M |
headless/lib/headless_browser_context_browsertest.cc
|
View
|
1
|
5 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
headless/lib/headless_devtools_client_browsertest.cc
|
View
|
1
2
3
|
8 chunks |
+24 lines, -7 lines |
0 comments
|
Download
|
|
M |
headless/lib/headless_web_contents_browsertest.cc
|
View
|
|
4 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
|
M |
headless/public/headless_browser.h
|
View
|
1
2
3
|
2 chunks |
+12 lines, -4 lines |
0 comments
|
Download
|
|
M |
headless/public/headless_browser_context.h
|
View
|
1
2
3
|
2 chunks |
+17 lines, -1 line |
0 comments
|
Download
|
|
M |
headless/test/headless_browser_test.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
headless/test/headless_browser_test.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
A + |
headless/testserver.log
|
View
|
1
2
3
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
Total messages: 15 (8 generated)
|