Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: src/heap/heap.cc

Issue 2210263002: [heap] Improve size profiling for ArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Added tests and some more fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 7320be3ad2f44cc3b5599ab674b9c49893aafe13..cfad5a0ddfe2b9209ff5818db4f0dd408eaaf398 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -163,7 +163,8 @@ Heap::Heap()
deserialization_complete_(false),
strong_roots_list_(NULL),
heap_iterator_depth_(0),
- force_oom_(false) {
+ force_oom_(false),
+ array_buffer_tracker_(nullptr) {
// Allow build-time customization of the max semispace size. Building
// V8 with snapshots and a non-default max semispace size is much
// easier if you can define it as part of the build environment.
@@ -1717,7 +1718,7 @@ void Heap::Scavenge() {
// Set age mark.
new_space_.set_age_mark(new_space_.top());
- ArrayBufferTracker::FreeDeadInNewSpace(this);
+ array_buffer_tracker()->FreeDeadInNewSpace(this);
// Update how much has survived scavenge.
IncrementYoungSurvivorsCounter(static_cast<int>(
@@ -2003,12 +2004,12 @@ HeapObject* Heap::DoubleAlignForDeserialization(HeapObject* object, int size) {
void Heap::RegisterNewArrayBuffer(JSArrayBuffer* buffer) {
- ArrayBufferTracker::RegisterNew(this, buffer);
+ array_buffer_tracker()->RegisterNew(this, buffer);
}
void Heap::UnregisterArrayBuffer(JSArrayBuffer* buffer) {
- ArrayBufferTracker::Unregister(this, buffer);
+ array_buffer_tracker()->Unregister(this, buffer);
}
@@ -5357,6 +5358,8 @@ bool Heap::SetUp() {
*this, ScavengeJob::kBytesAllocatedBeforeNextIdleTask);
new_space()->AddAllocationObserver(idle_scavenge_observer_);
+ array_buffer_tracker_ = new ArrayBufferTracker(this);
+
return true;
}
@@ -5557,6 +5560,9 @@ void Heap::TearDown() {
delete store_buffer_;
store_buffer_ = nullptr;
+ delete array_buffer_tracker_;
+ array_buffer_tracker_ = nullptr;
+
delete memory_allocator_;
memory_allocator_ = nullptr;
}
« src/heap/heap.h ('K') | « src/heap/heap.h ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698