Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: src/heap/array-buffer-tracker-inl.h

Issue 2210263002: [heap] Improve size profiling for ArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Added tests and some more fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/array-buffer-tracker-inl.h
diff --git a/src/heap/array-buffer-tracker-inl.h b/src/heap/array-buffer-tracker-inl.h
index 27c593d0f073e9d35e7b1a97da65da5473b64aef..dd023c7e380892a6c49d5ed62c3323406ef49f25 100644
--- a/src/heap/array-buffer-tracker-inl.h
+++ b/src/heap/array-buffer-tracker-inl.h
@@ -24,6 +24,11 @@ void ArrayBufferTracker::RegisterNew(Heap* heap, JSArrayBuffer* buffer) {
tracker = page->local_tracker();
}
DCHECK_NOT_NULL(tracker);
+ if (heap->InNewSpace(buffer)) {
+ retained_from_new_space_.Increment(static_cast<intptr_t>(length));
+ } else {
+ retained_from_old_space_.Increment(static_cast<intptr_t>(length));
+ }
tracker->Add(buffer, length);
}
// We may go over the limit of externally allocated memory here. We call the
@@ -43,6 +48,11 @@ void ArrayBufferTracker::Unregister(Heap* heap, JSArrayBuffer* buffer) {
LocalArrayBufferTracker* tracker = page->local_tracker();
DCHECK_NOT_NULL(tracker);
length = tracker->Remove(buffer);
+ if (heap->InNewSpace(buffer)) {
+ retained_from_new_space_.Increment(-static_cast<intptr_t>(length));
+ } else {
+ retained_from_old_space_.Increment(-static_cast<intptr_t>(length));
+ }
}
heap->update_external_memory(-static_cast<intptr_t>(length));
}

Powered by Google App Engine
This is Rietveld 408576698