[heap] Improve size profiling for ArrayBuffer tracking

src/heap/heap.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_HEAP_H_
 #define V8_HEAP_HEAP_H_
 
 #include <cmath>
 #include <map>
 
@@ skipping 827 matching lines @@
   // disposal. We use it to flush inline caches.
   int global_ic_age() { return global_ic_age_; }
 
   void AgeInlineCaches() {
     global_ic_age_ = (global_ic_age_ + 1) & SharedFunctionInfo::ICAgeBits::kMax;
   }
 
   int64_t external_memory() { return external_memory_; }
   void update_external_memory(int64_t delta) { external_memory_ += delta; }
 
-  void update_external_memory_concurrently_freed(intptr_t freed) {
-    external_memory_concurrently_freed_.Increment(freed);
-  }
-
-  void account_external_memory_concurrently_freed() {
-    external_memory_ -= external_memory_concurrently_freed_.Value();
-    external_memory_concurrently_freed_.SetValue(0);
-  }
-
   void DeoptMarkedAllocationSites();
 
   bool DeoptMaybeTenuredAllocationSites() {
     return new_space_.IsAtMaximumCapacity() && maximum_size_scavenges_ == 0;
   }
 
   void AddWeakNewSpaceObjectToCodeDependency(Handle<HeapObject> obj,
                                              Handle<WeakCell> code);
 
   void AddWeakObjectToCodeDependency(Handle<HeapObject> obj,
@@ skipping 550 matching lines @@
   inline void RemoveAllocationSitePretenuringFeedback(AllocationSite* site);
 
   // Merges local pretenuring feedback into the global one. Note that this
   // method needs to be called after evacuation, as allocation sites may be
   // evacuated and this method resolves forward pointers accordingly.
   void MergeAllocationSitePretenuringFeedback(
       const base::HashMap& local_pretenuring_feedback);
 
 // =============================================================================
 
+  ArrayBufferTracker* array_buffer_tracker() { return array_buffer_tracker_; }

[Hannes Payer (out of office), 2016/08/05 12:14:13]

Move this one to the ArrayBuffer tracking section.

[Michael Lippautz, 2016/08/08 08:34:46]

Done.

+
 #ifdef VERIFY_HEAP
   // Verify the heap is in its normal state before or after a GC.
   void Verify();
 #endif
 
 #ifdef DEBUG
   void set_allocation_timeout(int timeout) { allocation_timeout_ = timeout; }
 
   void TracePathToObjectFrom(Object* target, Object* root);
   void TracePathToObject(Object* target);
@@ skipping 587 matching lines @@
 
   // The amount of external memory registered through the API.
   int64_t external_memory_;
 
   // The limit when to trigger memory pressure from the API.
   int64_t external_memory_limit_;
 
   // Caches the amount of external memory registered at the last MC.
   int64_t external_memory_at_last_mark_compact_;
 
-  // The amount of memory that has been freed concurrently.
-  base::AtomicNumber<intptr_t> external_memory_concurrently_freed_;
-
   // This can be calculated directly from a pointer to the heap; however, it is
   // more expedient to get at the isolate directly from within Heap methods.
   Isolate* isolate_;
 
   Object* roots_[kRootListLength];
 
   size_t code_range_size_;
   int max_semi_space_size_;
   int initial_semispace_size_;
   intptr_t max_old_generation_size_;
@@ skipping 225 matching lines @@
   bool deserialization_complete_;
 
   StrongRootsList* strong_roots_list_;
 
   // The depth of HeapIterator nestings.
   int heap_iterator_depth_;
 
   // Used for testing purposes.
   bool force_oom_;
 
+  ArrayBufferTracker* array_buffer_tracker_;

[Hannes Payer (out of office), 2016/08/05 12:14:14]

We usually add comments to all variables in heap.h

[Michael Lippautz, 2016/08/08 08:34:46]

That's not really true, but done ;)

+
   // Classes in "heap" can be friends.
   friend class AlwaysAllocateScope;
   friend class GCCallbacksScope;
   friend class GCTracer;
   friend class HeapIterator;
   friend class IdleScavengeObserver;
   friend class IncrementalMarking;
   friend class IteratePromotedObjectsVisitor;
   friend class MarkCompactCollector;
   friend class MarkCompactMarkingVisitor;
@@ skipping 406 matching lines @@
   friend class LargeObjectSpace;
   friend class NewSpace;
   friend class PagedSpace;
   DISALLOW_COPY_AND_ASSIGN(AllocationObserver);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_HEAP_H_