Added a runtime flag for the MQ parser

Added a runtime flag for the MQ parser

To make sure that the new MediaQueryParser doesn't cause compatibility issues in M35, it was disabled for main thread MQ evaluation in https://codereview.chromium.org/219183002/ .
This CL adds a runtime flag that would enable turning it back on.

BUG=358078
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170715

[Yoav Weiss, 2014-04-01 14:40:09]

A followup to yesterday's https://codereview.chromium.org/219183002/

[eseidel, 2014-04-01 15:25:05]

Lgtm even though it won't count from mail.

On Tuesday, April 1, 2014, <yoav@yoav.ws> wrote:

> Reviewers: eseidel,
>
> Message:
> A followup to yesterday's https://codereview.chromium.org/219183002/
>
> Description:
> Added a runtime flag for the MQ parser
>
> To make sure that the new MediaQueryParser doesn't cause compatibility
> issues in
> M35, it was disabled for main thread MQ evaluation in
> https://codereview.chromium.org/219183002/ .
> This CL adds a runtime flag that would enable turning it back on.
>
> BUG=358078
>
> Please review this at https://codereview.chromium.org/221023002/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+4, -0 lines):
>   M Source/core/css/MediaList.cpp
>   M Source/platform/RuntimeEnabledFeatures.in
>
>
> Index: Source/core/css/MediaList.cpp
> diff --git a/Source/core/css/MediaList.cpp b/Source/core/css/MediaList.cpp
> index 8fc86c2c42a1715f363715fcfc9df3e0113fc9f0..
> ab8603c3a0baa49b1ac2a5186894c1c3fb912973 100644
> --- a/Source/core/css/MediaList.cpp
> +++ b/Source/core/css/MediaList.cpp
> @@ -71,6 +71,9 @@ PassRefPtrWillBeRawPtr<MediaQuerySet>
> MediaQuerySet::create(const String& mediaS
>      if (mediaString.isEmpty())
>          return MediaQuerySet::create();
>
> +    if (RuntimeEnabledFeatures::mediaQueryParserEnabled())
> +        return MediaQueryParser::parse(mediaString);
> +
>      BisonCSSParser parser(strictCSSParserContext());
>      return parser.parseMediaQueryList(mediaString);
>  }
> Index: Source/platform/RuntimeEnabledFeatures.in
> diff --git a/Source/platform/RuntimeEnabledFeatures.in b/Source/platform/
> RuntimeEnabledFeatures.in
> index 2f95def83a48b10e403ba9e13c384f58d164dd12..
> b7c4e799894c17db7b4a80db5b37bf8c1e7288a9 100644
> --- a/Source/platform/RuntimeEnabledFeatures.in
> +++ b/Source/platform/RuntimeEnabledFeatures.in
> @@ -69,6 +69,7 @@ LangAttributeAwareFormControlUI
>  PrefixedEncryptedMedia status=stable
>  LocalStorage status=stable
>  Media status=stable
> +MediaQueryParser status=test
>  MediaSource status=stable
>  MediaSourceExperimental depends_on=MediaSource, status=experimental
>  MediaStream status=stable
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[eseidel, 2014-04-01 15:25:54]

lgtm

[commit-bot: I haz the power, 2014-04-01 15:26:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/221023002/1

[commit-bot: I haz the power, 2014-04-01 15:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 15:39:44]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Yoav Weiss, 2014-04-01 15:54:34]

On 2014/04/01 15:39:44, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on mac_blink_rel

Hmm. Landing https://codereview.chromium.org/217423005/ will make this failure
go away.

[Yoav Weiss, 2014-04-02 21:19:45]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-04-02 21:19:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/221023002/20001

[commit-bot: I haz the power, 2014-04-02 23:17:00]

Change committed as 170715