chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc - Issue 2210143003: arc: Handle non-launchable apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2210143003: arc: Handle non-launchable apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + simplify mojo declaration Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc ('k') | chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc » ('j') | components/arc/common/app.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

index 9fd7fe32d2da27ff9e43d5a09090bcfbaa3fef37..a3a7e4f74e0dc2d8a3690cc888f67847e4c73bd9 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

@@ -872,7 +872,7 @@ class ChromeLauncherControllerImplTest : public BrowserWithTestWindowTest {

app_info.name, app_info.package_name, app_info.activity,

std::string() /* intent_uri */, std::string() /* icon_resource_id */,

false /* sticky */, true /* notifications_enabled */,

- false /* shortcut */, app_info.orientation_lock);

+ false /* shortcut */, true /* launchable */, app_info.orientation_lock);

const std::string app_id =

ArcAppListPrefs::GetAppId(app_info.package_name, app_info.activity);

EXPECT_TRUE(prefs->GetApp(app_id));

@@ -882,7 +882,8 @@ class ChromeLauncherControllerImplTest : public BrowserWithTestWindowTest {

void NotifyOnTaskCreated(const arc::mojom::AppInfo& appinfo,

int32_t task_id) {

ArcAppListPrefs* const prefs = arc_test_.arc_app_list_prefs();

- prefs->OnTaskCreated(task_id, appinfo.package_name, appinfo.activity);

+ prefs->OnTaskCreated(task_id, appinfo.name, appinfo.package_name,

+ appinfo.activity);

}

void NotifyOnTaskOrientationLockRequested(int32_t task_id,