chrome/browser/ui/app_list/arc/arc_app_utils.cc - Issue 2210143003: arc: Handle non-launchable apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_utils.cc

Issue 2210143003: arc: Handle non-launchable apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment fixed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/arc/arc_app_utils.cc

diff --git a/chrome/browser/ui/app_list/arc/arc_app_utils.cc b/chrome/browser/ui/app_list/arc/arc_app_utils.cc

index 651bbb810361a9124fd6892fb53364398162094d..9c0ee793e8ecb73ad8439f6ad771822967826322 100644

--- a/chrome/browser/ui/app_list/arc/arc_app_utils.cc

+++ b/chrome/browser/ui/app_list/arc/arc_app_utils.cc

@@ -182,6 +182,11 @@ bool LaunchAppWithRect(content::BrowserContext* context,

return false;

}

+ if (!app_info->launchable) {

+ VLOG(2) << "Cannot launch not-launchable app: " << app_id << ".";

xiyuan 2016/08/05 17:39:39 nit: not-launchable -> non-launchable to be consis

khmel 2016/08/05 18:28:35 Done.

+ return false;

+ }

arc::mojom::AppInstance* app_instance =

GetAppInstance(kMinVersion, kLaunchAppStr);

if (!app_instance)