Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 2210123002: Improved heuristic for disable acceleration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable trackDrawCall when Canvas 2D Dynamic Rendering Mode Switching is disabled Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
index baa008606aa270dee1285506c565e58a9ef0362e..e4280319daa0c1f524c4fd47427da57895296939 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
@@ -1070,28 +1070,20 @@ unsigned CanvasRenderingContext2D::hitRegionsCount() const
bool CanvasRenderingContext2D::isAccelerationOptimalForCanvasContent() const
{
- // Simple heuristic to determine if the GPU accelerated pipeline should be
- // used to maximize performance of 2D canvas based on past usage.
-
- int numDrawPathCalls =
- m_usageCounters.numDrawCalls[StrokePath] +
- m_usageCounters.numDrawCalls[FillPath] +
- m_usageCounters.numDrawCalls[FillText] +
- m_usageCounters.numDrawCalls[StrokeText] +
- m_usageCounters.numDrawCalls[FillRect] +
- m_usageCounters.numDrawCalls[StrokeRect];
-
- double acceleratedCost =
- numDrawPathCalls * ExpensiveCanvasHeuristicParameters::AcceleratedDrawPathApproximateCost +
- m_usageCounters.numGetImageDataCalls * ExpensiveCanvasHeuristicParameters::AcceleratedGetImageDataApproximateCost+
- m_usageCounters.numDrawCalls[DrawImage] * ExpensiveCanvasHeuristicParameters::AcceleratedDrawImageApproximateCost;
-
- double recordingCost =
- numDrawPathCalls * ExpensiveCanvasHeuristicParameters::RecordingDrawPathApproximateCost +
- m_usageCounters.numGetImageDataCalls * ExpensiveCanvasHeuristicParameters::UnacceleratedGetImageDataApproximateCost +
- m_usageCounters.numDrawCalls[DrawImage] * ExpensiveCanvasHeuristicParameters::RecordingDrawImageApproximateCost;
-
- if (recordingCost * ExpensiveCanvasHeuristicParameters::AcceleratedHeuristicBias < acceleratedCost) {
+ // Heuristic to determine if the GPU accelerated rendering pipeline is optimal
+ // for performance based on past usage. It has a bias towards suggesting that the
+ // accelerated pipeline is optimal.
+
+ float acceleratedCost = estimateRenderingCost(ExpensiveCanvasHeuristicParameters::AcceleratedModeIndex);
+
+ float recordingCost = estimateRenderingCost(ExpensiveCanvasHeuristicParameters::RecordingModeIndex);
+
+ float costDifference = acceleratedCost - recordingCost;
+ float percentCostReduction = costDifference / acceleratedCost * 100.0;
+ float costDifferencePerFrame = costDifference / m_usageCounters.numFramesSinceReset;
+
+ if (percentCostReduction >= ExpensiveCanvasHeuristicParameters::MinPercentageImprovementToSuggestDisableAcceleration
+ && costDifferencePerFrame >= ExpensiveCanvasHeuristicParameters::MinCostPerFrameImprovementToSuggestDisableAcceleration) {
return false;
}
return true;

Powered by Google App Engine
This is Rietveld 408576698