Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2210063002: MD Settings: add a <controlled-radio-button> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove radio-group tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index 195d357878e4dfb58bd38bd6fd51d64eabf83f58..0936c4186f18ecf2e81b57df134e0a464ceaeda2 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -4,8 +4,8 @@
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/paper-radio-button.html">
<link rel="import" href="/appearance_page/appearance_browser_proxy.html">
+<link rel="import" href="/controls/controlled_radio_button.html">
<link rel="import" href="/controls/settings_dropdown_menu.html">
<link rel="import" href="/controls/settings_input.html">
<link rel="import" href="/controls/settings_radio_group.html">
@@ -72,16 +72,21 @@
<div class="list-frame"
hidden="[[!pageVisibility.homeButton]]">
<settings-radio-group pref="{{prefs.homepage_is_newtabpage}}">
- <paper-radio-button class="list-item" name="true">
+ <controlled-radio-button class="list-item" name="true"
+ pref="[[prefs.homepage_is_newtabpage]]">
$i18n{homePageNtp}
- </paper-radio-button>
- <paper-radio-button class="list-item" name="false">
+ </controlled-radio-button>
+ <controlled-radio-button class="list-item" name="false"
+ pref="[[prefs.homepage_is_newtabpage]]">
$i18n{other}
+ <!-- TODO(dbeam): this can show double indicators when both
+ homepage and whether to use the NTP as the homepage are
+ managed. -->
<settings-input no-label-float pref="{{prefs.homepage}}"
label="$i18n{exampleDotCom}"
stop-keyboard-event-propagation>
</settings-input>
- </paper-radio-button>
+ </controlled-radio-button>
</settings-radio-group>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698