Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/controls/controlled_button.js

Issue 2210043002: MD Settings: add tests for <controlled-button> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/controlled_button_tests.js » ('j') | chrome/test/data/webui/settings/controlled_button_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/controlled_button.js
diff --git a/chrome/browser/resources/settings/controls/controlled_button.js b/chrome/browser/resources/settings/controls/controlled_button.js
index a072e37d91a1e3c5efce8b680a1533821033abb8..a3dc81ba56a9b8dca4f588951f87d098edf61256 100644
--- a/chrome/browser/resources/settings/controls/controlled_button.js
+++ b/chrome/browser/resources/settings/controls/controlled_button.js
@@ -11,17 +11,17 @@ Polymer({
/** @private */
controlled_: {
type: Boolean,
- computed: 'computeControlled_(pref)',
+ computed: 'computeControlled_(pref.*)',
reflectToAttribute: true,
},
},
/**
- * @param {!chrome.settingsPrivate.PrefObject} pref
* @return {boolean} Whether the button is disabled.
* @private
*/
- computeControlled_: function(pref) {
+ computeControlled_: function() {
+ var pref = /** @type {chrome.settingsPrivate.PrefObject} */(this.pref);
michaelpg 2016/08/04 17:54:23 isn't this already typed?
Dan Beam 2016/08/04 22:26:42 yeah, but as |undefined, wrapped in an assert() in
return this.isPrefPolicyControlled(pref);
},
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/controlled_button_tests.js » ('j') | chrome/test/data/webui/settings/controlled_button_tests.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698