MD Settings: add tests for <controlled-button>

chrome/browser/resources/settings/controls/controlled_button.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'controlled-button',
 
   behaviors: [CrPolicyPrefBehavior, PrefControlBehavior],
 
   properties: {
     /** @private */
     controlled_: {
       type: Boolean,
-      computed: 'computeControlled_(pref)',
+      computed: 'computeControlled_(pref.*)',
       reflectToAttribute: true,
     },
   },
 
   /**
-   * @param {!chrome.settingsPrivate.PrefObject} pref
    * @return {boolean} Whether the button is disabled.
    * @private
    */
-  computeControlled_: function(pref) {
+  computeControlled_: function() {
+    var pref = /** @type {chrome.settingsPrivate.PrefObject} */(this.pref);

[michaelpg, 2016/08/04 17:54:23]

isn't this already typed?

[Dan Beam, 2016/08/04 22:26:42]

yeah, but as |undefined, wrapped in an assert() instead

     return this.isPrefPolicyControlled(pref);
   },
 
   /**
    * @param {!Event} e
    * @private
    */
   onIndicatorTap_: function(e) {
     // Disallow <controlled-button on-tap="..."> when controlled.
     e.preventDefault();
     e.stopPropagation();
   },
 });