MD Settings: add tests for <controlled-button>

MD Settings: add tests for <controlled-button>

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7134c054160f414eaf70dc94d8faccb797981cfa
Cr-Commit-Position: refs/heads/master@{#409937}

[Dan Beam, 2016-08-04 00:31:50]

Description was changed from

==========
MD Settings: add tests for <controlled-button>

R=michaelpg@chromium.org
BUG=614265
==========

to

==========
MD Settings: add tests for <controlled-button>

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-08-04 00:33:40]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-08-04 00:34:21]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 00:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 00:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 00:39:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaelpg, 2016-08-04 17:54:23]

https://codereview.chromium.org/2210043002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.js (right):

https://codereview.chromium.org/2210043002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.js:24: var pref =
/** @type {chrome.settingsPrivate.PrefObject} */(this.pref);
isn't this already typed?

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/controlled_button_tests.js (right):

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/controlled_button_tests.js:19:
button.set('pref', pref);
button.pref = pref

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/controlled_button_tests.js:28:
assertTrue(!!button.$$('cr-policy-pref-indicator'));
check clientHeight > 0

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/controlled_button_tests.js:33:
assertEquals('none', button.$$('cr-policy-pref-indicator').style.display);
i'd suggest the same here... this is implementation-dependent and verbose

[Dan Beam, 2016-08-04 22:24:16]

Patchset #3 (id:60001) has been deleted

[Dan Beam, 2016-08-04 22:26:42]

https://codereview.chromium.org/2210043002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.js (right):

https://codereview.chromium.org/2210043002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.js:24: var pref =
/** @type {chrome.settingsPrivate.PrefObject} */(this.pref);
On 2016/08/04 17:54:23, michaelpg wrote:
> isn't this already typed?

yeah, but as |undefined, wrapped in an assert() instead

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/controlled_button_tests.js (right):

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/controlled_button_tests.js:19:
button.set('pref', pref);
On 2016/08/04 17:54:23, michaelpg wrote:
> button.pref = pref

Done.

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/controlled_button_tests.js:28:
assertTrue(!!button.$$('cr-policy-pref-indicator'));
On 2016/08/04 17:54:23, michaelpg wrote:
> check clientHeight > 0

Done.

https://codereview.chromium.org/2210043002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/controlled_button_tests.js:33:
assertEquals('none', button.$$('cr-policy-pref-indicator').style.display);
On 2016/08/04 17:54:23, michaelpg wrote:
> i'd suggest the same here... this is implementation-dependent and verbose

Done.

[michaelpg, 2016-08-04 22:50:55]

lgtm

[Dan Beam, 2016-08-04 22:54:38]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:55:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 23:58:21]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-04 23:59:41]

Description was changed from

==========
MD Settings: add tests for <controlled-button>

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: add tests for <controlled-button>

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7134c054160f414eaf70dc94d8faccb797981cfa
Cr-Commit-Position: refs/heads/master@{#409937}
==========

[commit-bot: I haz the power, 2016-08-04 23:59:42]

Patchset 3 (id:??) landed as
https://crrev.com/7134c054160f414eaf70dc94d8faccb797981cfa
Cr-Commit-Position: refs/heads/master@{#409937}