Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2210023002: [MD settings] remove unused underscore class (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove unused underscore class This CL cleans up some undefined .underscore class entries that were having no effect. BUG=543635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/dc760c98f1299a7b40056237f748047206fa569b Cr-Commit-Position: refs/heads/master@{#409696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/site_settings/protocol_handlers.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
dschuyler
4 years, 4 months ago (2016-08-04 00:24:26 UTC) #6
tommycli
lgtm
4 years, 4 months ago (2016-08-04 00:27:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210023002/1
4 years, 4 months ago (2016-08-04 01:30:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 01:35:51 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 01:37:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc760c98f1299a7b40056237f748047206fa569b
Cr-Commit-Position: refs/heads/master@{#409696}

Powered by Google App Engine
This is Rietveld 408576698