Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: content/shell/browser/layout_test/layout_test_android.cc

Issue 2209993003: Add missing using statements for JNI types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/android/shell_manager.cc ('k') | content/shell/browser/shell_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/layout_test/layout_test_android.h" 5 #include "content/shell/browser/layout_test/layout_test_android.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/android/context_utils.h" 9 #include "base/android/context_utils.h"
10 #include "base/android/fifo_utils.h" 10 #include "base/android/fifo_utils.h"
11 #include "base/android/jni_android.h" 11 #include "base/android/jni_android.h"
12 #include "base/android/jni_string.h" 12 #include "base/android/jni_string.h"
13 #include "base/command_line.h" 13 #include "base/command_line.h"
14 #include "base/files/file_path.h" 14 #include "base/files/file_path.h"
15 #include "base/message_loop/message_loop.h" 15 #include "base/message_loop/message_loop.h"
16 #include "content/public/test/nested_message_pump_android.h" 16 #include "content/public/test/nested_message_pump_android.h"
17 #include "content/shell/common/shell_switches.h" 17 #include "content/shell/common/shell_switches.h"
18 #include "jni/ShellLayoutTestUtils_jni.h" 18 #include "jni/ShellLayoutTestUtils_jni.h"
19 #include "url/gurl.h" 19 #include "url/gurl.h"
20 20
21 using base::android::ScopedJavaLocalRef;
22
21 namespace { 23 namespace {
22 24
23 base::FilePath GetTestFilesDirectory(JNIEnv* env) { 25 base::FilePath GetTestFilesDirectory(JNIEnv* env) {
24 ScopedJavaLocalRef<jstring> directory = 26 ScopedJavaLocalRef<jstring> directory =
25 content::Java_ShellLayoutTestUtils_getApplicationFilesDirectory( 27 content::Java_ShellLayoutTestUtils_getApplicationFilesDirectory(
26 env, base::android::GetApplicationContext()); 28 env, base::android::GetApplicationContext());
27 return base::FilePath(ConvertJavaStringToUTF8(directory)); 29 return base::FilePath(ConvertJavaStringToUTF8(directory));
28 } 30 }
29 31
30 void EnsureCreateFIFO(const base::FilePath& path) { 32 void EnsureCreateFIFO(const base::FilePath& path) {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // Redirecting stdout needs to happen before redirecting stdin, which needs 68 // Redirecting stdout needs to happen before redirecting stdin, which needs
67 // to happen before redirecting stderr. 69 // to happen before redirecting stderr.
68 success = base::android::RedirectStream(stdout, stdout_fifo, "w") && 70 success = base::android::RedirectStream(stdout, stdout_fifo, "w") &&
69 base::android::RedirectStream(stdin, stdin_fifo, "r") && 71 base::android::RedirectStream(stdin, stdin_fifo, "r") &&
70 base::android::RedirectStream(stderr, stderr_fifo, "w"); 72 base::android::RedirectStream(stderr, stderr_fifo, "w");
71 73
72 CHECK(success) << "Unable to initialize the Android FIFOs."; 74 CHECK(success) << "Unable to initialize the Android FIFOs.";
73 } 75 }
74 76
75 } // namespace content 77 } // namespace content
OLDNEW
« no previous file with comments | « content/shell/android/shell_manager.cc ('k') | content/shell/browser/shell_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698