Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: android_webview/native/aw_debug.cc

Issue 2209993003: Add missing using statements for JNI types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_debug.h" 5 #include "android_webview/native/aw_debug.h"
6 6
7 #include "android_webview/crash_reporter/aw_microdump_crash_reporter.h" 7 #include "android_webview/crash_reporter/aw_microdump_crash_reporter.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/debug/dump_without_crashing.h" 10 #include "base/debug/dump_without_crashing.h"
11 #include "base/files/file.h" 11 #include "base/files/file.h"
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/threading/thread_restrictions.h" 13 #include "base/threading/thread_restrictions.h"
14 #include "jni/AwDebug_jni.h" 14 #include "jni/AwDebug_jni.h"
15 15
16 using base::android::ConvertJavaStringToUTF16; 16 using base::android::ConvertJavaStringToUTF16;
17 using base::android::ConvertUTF8ToJavaString; 17 using base::android::ConvertUTF8ToJavaString;
18 using base::android::JavaParamRef;
18 using base::android::ScopedJavaLocalRef; 19 using base::android::ScopedJavaLocalRef;
19 20
20 namespace android_webview { 21 namespace android_webview {
21 22
22 static jboolean DumpWithoutCrashing(JNIEnv* env, 23 static jboolean DumpWithoutCrashing(JNIEnv* env,
23 const JavaParamRef<jclass>& clazz, 24 const JavaParamRef<jclass>& clazz,
24 const JavaParamRef<jstring>& dump_path) { 25 const JavaParamRef<jstring>& dump_path) {
25 // This may be called from any thread, and we might be in a state 26 // This may be called from any thread, and we might be in a state
26 // where it is impossible to post tasks, so we have to be prepared 27 // where it is impossible to post tasks, so we have to be prepared
27 // to do IO from this thread. 28 // to do IO from this thread.
28 base::ThreadRestrictions::ScopedAllowIO allow_io; 29 base::ThreadRestrictions::ScopedAllowIO allow_io;
29 base::File target(base::FilePath(ConvertJavaStringToUTF8(env, dump_path)), 30 base::File target(base::FilePath(ConvertJavaStringToUTF8(env, dump_path)),
30 base::File::FLAG_OPEN_TRUNCATED | base::File::FLAG_READ | 31 base::File::FLAG_OPEN_TRUNCATED | base::File::FLAG_READ |
31 base::File::FLAG_WRITE); 32 base::File::FLAG_WRITE);
32 if (!target.IsValid()) 33 if (!target.IsValid())
33 return false; 34 return false;
34 // breakpad_linux::HandleCrashDump will close this fd once it is done. 35 // breakpad_linux::HandleCrashDump will close this fd once it is done.
35 return crash_reporter::DumpWithoutCrashingToFd(target.TakePlatformFile()); 36 return crash_reporter::DumpWithoutCrashingToFd(target.TakePlatformFile());
36 } 37 }
37 38
38 bool RegisterAwDebug(JNIEnv* env) { 39 bool RegisterAwDebug(JNIEnv* env) {
39 return RegisterNativesImpl(env); 40 return RegisterNativesImpl(env);
40 } 41 }
41 42
42 } // namespace android_webview 43 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_contents_statics.cc ('k') | android_webview/native/aw_dev_tools_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698