chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js - Issue 2209993002: Remove the GetStatus() call from SavePageRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

Issue 2209993002: Remove the GetStatus() call from SavePageRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback from DougArnett and Chili Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

diff --git a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

index 1316c9d696e60038a6ebfead8ea6c38dbd9fb44c..5025d383fd5a2468df0fd50c871fba0edc1019e7 100644

--- a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

+++ b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

@@ -19,7 +19,6 @@ var OfflinePage;

/**

* @typedef {{

- * status: string,

chili 2016/08/04 01:25:46 Oh, sorry... if you're going to leave status as is

* onlineUrl: string,

* creationTime: number,

* id: string,

« no previous file with comments | « no previous file | chrome/browser/ui/webui/offline_internals_ui.cc » ('j') | no next file with comments »