Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Side by Side Diff: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

Issue 2209993002: Remove the GetStatus() call from SavePageRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback from DougArnett and Chili Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/offline_internals_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{ 6 * @typedef {{
7 * onlineUrl: string, 7 * onlineUrl: string,
8 * creationTime: number, 8 * creationTime: number,
9 * id: string, 9 * id: string,
10 * namespace: string, 10 * namespace: string,
11 * size: string, 11 * size: string,
12 * filePath: string, 12 * filePath: string,
13 * lastAccessTime: number, 13 * lastAccessTime: number,
14 * accessCount: number, 14 * accessCount: number,
15 * isExpired: string 15 * isExpired: string
16 * }} 16 * }}
17 */ 17 */
18 var OfflinePage; 18 var OfflinePage;
19 19
20 /** 20 /**
21 * @typedef {{ 21 * @typedef {{
22 * status: string,
chili 2016/08/04 01:25:46 Oh, sorry... if you're going to leave status as is
23 * onlineUrl: string, 22 * onlineUrl: string,
24 * creationTime: number, 23 * creationTime: number,
25 * id: string, 24 * id: string,
26 * namespace: string, 25 * namespace: string,
27 * lastAttempt: number 26 * lastAttempt: number
28 * }} 27 * }}
29 */ 28 */
30 var SavePageRequest; 29 var SavePageRequest;
31 30
32 /** 31 /**
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 getNetworkStatus: function() { 168 getNetworkStatus: function() {
170 return cr.sendWithPromise('getNetworkStatus'); 169 return cr.sendWithPromise('getNetworkStatus');
171 }, 170 },
172 }; 171 };
173 172
174 return { 173 return {
175 OfflineInternalsBrowserProxy: OfflineInternalsBrowserProxy, 174 OfflineInternalsBrowserProxy: OfflineInternalsBrowserProxy,
176 OfflineInternalsBrowserProxyImpl: OfflineInternalsBrowserProxyImpl 175 OfflineInternalsBrowserProxyImpl: OfflineInternalsBrowserProxyImpl
177 }; 176 };
178 }); 177 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/offline_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698