content/browser/service_worker/service_worker_register_job.cc - Issue 2209963002: Record some foreign fetch registration metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 2209963002: Record some foreign fetch registration metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better histogram summaries Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index b6125adcb1a3cd6c9b1b53c56484531aff98081a..33fa4e88c28c22cff9436c65a01160aa0f4b3132 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -463,6 +463,9 @@ void ServiceWorkerRegisterJob::OnInstallFinished(

}

ServiceWorkerMetrics::RecordInstallEventStatus(status);

+ ServiceWorkerMetrics::RecordForeignFetchRegistrationCount(

+ new_version()->foreign_fetch_scopes().size(),

+ new_version()->foreign_fetch_origins().size());

SetPhase(STORE);

DCHECK(!registration()->last_update_check().is_null());