Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 4bd5e86b0386cb9748d21c8fc5fa7ba483fadd51..30c5baa6de8efcfcdcbda571e96e57cc115b98e0 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -51976,6 +51976,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="ServiceWorker.ForeignFetch.OriginCount"> |
| + <owner>mek@chromium.org</owner> |
| + <summary> |
| + The number of origins a particular service worker with foreign fetch |
| + registrations the worker will intercept fetches from. A value of zero |
| + indicates that the foreign fetch service worker intercepts requests from any |
| + origin. Recorded t the end of a successful install event, if the service |
|
Mark P
2016/08/11 22:42:18
"t" -> "at"?
Marijn Kruisselbrink
2016/08/12 20:33:23
fixed
|
| + worker register for foreign fetch. |
|
Mark P
2016/08/11 22:42:18
Can a service worker register for foreign fetch bu
Marijn Kruisselbrink
2016/08/12 20:33:23
No, hence why "all origins" is internally represen
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="ServiceWorker.ForeignFetch.SubScopeCount"> |
| + <owner>mek@chromium.org</owner> |
| + <summary> |
| + The number of subscopes a particular service worker registered for. Recorded |
|
Mark P
2016/08/11 22:42:18
Please briefly explain what a subscope is.
Marijn Kruisselbrink
2016/08/12 20:33:23
changed it to "foreign fetch scopes". And I'm not
|
| + at the end of every succesful install event. |
|
Mark P
2016/08/11 22:42:18
nit: every -> a
(to be identical to the sentence y
Marijn Kruisselbrink
2016/08/12 20:33:23
I think this is clearer by not having this be iden
Mark P
2016/08/16 22:27:14
Ah, thank you for pointing out the difference.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="ServiceWorker.ForeignFetchEvent.Fallback.Time" units="ms"> |
| <owner>mek@chromium.org</owner> |
| <summary> |