Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2209923002: MD Settings: Specify max-height for the "Edit address" dialog. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Specify max-height for the "Edit address" dialog. BUG=633555 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e9b7184afd9ac616fafe276f3172307538a2ff97 Cr-Commit-Position: refs/heads/master@{#409673}

Patch Set 1 #

Patch Set 2 : Add media query #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html View 1 1 chunk +27 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
Before/after screenshots at http://imgur.com/a/zbfg0. Perhaps we should specify a more sane default behavior in cr-dialog ...
4 years, 4 months ago (2016-08-03 21:20:07 UTC) #3
Dan Beam
lgtm
4 years, 4 months ago (2016-08-03 21:56:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209923002/20001
4 years, 4 months ago (2016-08-03 22:00:58 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
4 years, 4 months ago (2016-08-04 00:03:20 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 00:04:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9b7184afd9ac616fafe276f3172307538a2ff97
Cr-Commit-Position: refs/heads/master@{#409673}

Powered by Google App Engine
This is Rietveld 408576698