Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2209893003: Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a… (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function. Don't AddTypesOf(function) before the work queue is empty, or we may miss types in exception handlers that are not computed until the function is compiled. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/978abe4e3227959f7a5aa0582bc74e3b11ed1216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/precompiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-03 23:54:29 UTC) #2
Florian Schneider
Lgtm.
4 years, 4 months ago (2016-08-03 23:56:37 UTC) #3
rmacnak
4 years, 4 months ago (2016-08-03 23:58:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
978abe4e3227959f7a5aa0582bc74e3b11ed1216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698