Link blink mojom bindings into platform target

Link Blink mojom bindings into platform target.

The problem is that r406852 introduced a dependency from 
//third_party/WebKit/public:mojo_bindings to //url/mojo:url_mojom_origin
which the typemap translated to webkit's SecurityOrigin. This means that
mojo_bindings needs to set BLINK_PLATFORM_IMPLEMENTATION for the blink
variant and have that propagate to the generated target. Otherwise
SecurityOrigin is imported by mojo_bindings to blink_platform.dll,
which defines it.

The fix is to not link platform with mojom_bindings_blink variant, but
instead compile that variant with platform so that it gets its config.

BUG=632082

[jam, 2016-08-03 20:26:32]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:26:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 20:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:33:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-08-03 21:13:08]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 21:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:23:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-08-03 21:38:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2016-08-03 21:38:22]

Patchset #2 (id:20001) has been deleted

[jam, 2016-08-03 21:38:28]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-03 21:38:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:41:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:41:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-08-03 21:48:37]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2016-08-03 21:48:59]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-08-03 21:49:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:56:27]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-08-03 23:12:48]

Description was changed from

==========
Link blink mojom bindings into platform target
==========

to

==========
Link blink mojom bindings into platform target.

BUG=632082
==========

[esprehn, 2016-08-03 23:17:32]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-08-03 23:17:33]

This seems reasonable to me, is there a reason not to do this? :)

[jam, 2016-08-03 23:22:18]

On 2016/08/03 23:17:33, esprehn wrote:
> This seems reasonable to me, is there a reason not to do this? :)

The tradeoffs are the build file complexity: i.e. that the GN targets aren't
beside the source, that content/ is including targets from Source/, and the
blink_platform magic. I can see pros and cons to each solution, but I don't care
strongly if you or Jochen do.

[esprehn, 2016-08-04 05:15:49]

Can we do what's said here?
https://bugs.chromium.org/p/chromium/issues/detail?id=632082#c13

[jam, 2016-08-04 21:38:10]

Description was changed from

==========
Link blink mojom bindings into platform target.

BUG=632082
==========

to

==========
Link Blink mojom bindings into platform target.

The problem is that r406852 introduced a dependency from
//third_party/WebKit/public:mojo_bindings to //url/mojo:url_mojom_origin which
the typemap translated to webkit's SecurityOrigin. This means that mojo_bindings
needs to set BLINK_PLATFORM_IMPLEMENTATION for the blink variant and have that
propagate to the generated target. Otherwise SecurityOrigin is imported by
mojo_bindings to blink_platform.dll, which defines it.

The fix is to not link platform with mojom_bindings_blink variant, but instead
compile that variant with platform so that it gets its config.

BUG=632082
==========

[jam, 2016-08-04 21:54:09]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 21:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 21:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 21:59:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jam, 2016-08-05 00:11:49]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:18:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-08-05 19:54:13]

Looks like the thread settled on this solution. Do you have any more comments on
this patch or is this ready to land?

[esprehn, 2016-08-05 20:53:25]

Description was changed from

==========
Link Blink mojom bindings into platform target.

The problem is that r406852 introduced a dependency from
//third_party/WebKit/public:mojo_bindings to //url/mojo:url_mojom_origin which
the typemap translated to webkit's SecurityOrigin. This means that mojo_bindings
needs to set BLINK_PLATFORM_IMPLEMENTATION for the blink variant and have that
propagate to the generated target. Otherwise SecurityOrigin is imported by
mojo_bindings to blink_platform.dll, which defines it.

The fix is to not link platform with mojom_bindings_blink variant, but instead
compile that variant with platform so that it gets its config.

BUG=632082
==========

to

==========
Link Blink mojom bindings into platform target.

The problem is that r406852 introduced a dependency from
//third_party/WebKit/public:mojo_bindings to //url/mojo:url_mojom_origin
which the typemap translated to webkit's SecurityOrigin. This means that
mojo_bindings needs to set BLINK_PLATFORM_IMPLEMENTATION for the blink
variant and have that propagate to the generated target. Otherwise
SecurityOrigin is imported by mojo_bindings to blink_platform.dll,
which defines it.

The fix is to not link platform with mojom_bindings_blink variant, but
instead compile that variant with platform so that it gets its config.

BUG=632082
==========

[esprehn, 2016-08-05 20:53:37]

Description was changed from

==========
Link Blink mojom bindings into platform target.

The problem is that r406852 introduced a dependency from
//third_party/WebKit/public:mojo_bindings to //url/mojo:url_mojom_origin
which the typemap translated to webkit's SecurityOrigin. This means that
mojo_bindings needs to set BLINK_PLATFORM_IMPLEMENTATION for the blink
variant and have that propagate to the generated target. Otherwise
SecurityOrigin is imported by mojo_bindings to blink_platform.dll,
which defines it.

The fix is to not link platform with mojom_bindings_blink variant, but
instead compile that variant with platform so that it gets its config.

BUG=632082
==========

to

==========
Link Blink mojom bindings into platform target.

The problem is that r406852 introduced a dependency from 
//third_party/WebKit/public:mojo_bindings to //url/mojo:url_mojom_origin
which the typemap translated to webkit's SecurityOrigin. This means that
mojo_bindings needs to set BLINK_PLATFORM_IMPLEMENTATION for the blink
variant and have that propagate to the generated target. Otherwise
SecurityOrigin is imported by mojo_bindings to blink_platform.dll,
which defines it.

The fix is to not link platform with mojom_bindings_blink variant, but
instead compile that variant with platform so that it gets its config.

BUG=632082
==========

[esprehn, 2016-08-05 20:53:48]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org

[esprehn, 2016-08-05 20:53:49]

lgtm, haraken@ are you okay with this?

[jam, 2016-08-05 23:13:24]

actually hold off on reviews, it looks like we might need a different solution.

[haraken, 2016-08-06 00:43:51]

On 2016/08/05 20:53:49, esprehn wrote:
> lgtm, haraken@ are you okay with this?

Yes, LGTM