Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2209863002: Remove unused includes in pref_hash_browsertest.cc (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@b7_a_UNRELATED_pnacl_host_weakptr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused includes in pref_hash_browsertest.cc Mostly because I'm putting together a presentation on settings protection and showing that the integration tests treat everything as a blackbox (don't depend on components/prefs other than on histogram_names for reading). BUG=None TBR=bauerb Committed: https://crrev.com/5508d128fccecf2030a3515956bbe30b261fa2f5 Cr-Commit-Position: refs/heads/master@{#409613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
gab
TBR bauerb for no-op CL
4 years, 4 months ago (2016-08-03 19:26:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209863002/1
4 years, 4 months ago (2016-08-03 19:27:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 20:25:56 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:27:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5508d128fccecf2030a3515956bbe30b261fa2f5
Cr-Commit-Position: refs/heads/master@{#409613}

Powered by Google App Engine
This is Rietveld 408576698