Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2209843002: Expand scope of enable_hotwording. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand scope of enable_hotwording. It is currently only in chrome/browser/BUILD.gn even though it is used elsewhere. Moving it to chrome/common/features.gni and checking for it where it is used. BUG=634044 Committed: https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88 Cr-Commit-Position: refs/heads/master@{#409651}

Patch Set 1 #

Patch Set 2 : revert test value #

Patch Set 3 : sort #

Patch Set 4 : rebase #

Patch Set 5 : import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -71 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 2 5 chunks +61 lines, -56 lines 0 comments Download
M chrome/common/features.gni View 1 2 3 4 1 chunk +15 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Lei Zhang
4 years, 4 months ago (2016-08-03 21:24:32 UTC) #12
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 22:30:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209843002/80001
4 years, 4 months ago (2016-08-03 22:58:41 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-03 23:05:51 UTC) #18
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88 Cr-Commit-Position: refs/heads/master@{#409651}
4 years, 4 months ago (2016-08-03 23:07:25 UTC) #20
Lei Zhang
4 years, 4 months ago (2016-08-04 00:18:31 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2204343004/ by thestig@chromium.org.

The reason for reverting is: Broke official CrOS build..

Powered by Google App Engine
This is Rietveld 408576698