Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2209823002: Rename xfa_layout_pagemgr_new.h (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename xfa_layout_pagemgr_new.h This renames the file to match the class name. Committed: https://pdfium.googlesource.com/pdfium/+/8d0cc67cdf3ef45ee7268d3e00a21c0a99843a84

Patch Set 1 #

Patch Set 2 : static casts #

Patch Set 3 : formatting #

Total comments: 2

Patch Set 4 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -2342 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_containerlayoutitem.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxfa/parser/cxfa_layoutpagemgr.h View 2 chunks +4 lines, -16 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_layoutpagemgr.cpp View 1 2 80 chunks +255 lines, -209 lines 0 comments Download
M xfa/fxfa/parser/cxfa_layoutprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fxfa/parser/xfa_layout_pagemgr_new.h View 1 chunk +0 lines, -156 lines 0 comments Download
D xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 chunk +0 lines, -1954 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-03 18:23:43 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2209823002/diff/40001/xfa/fxfa/parser/cxfa_containerlayoutitem.cpp File xfa/fxfa/parser/cxfa_containerlayoutitem.cpp (right): https://codereview.chromium.org/2209823002/diff/40001/xfa/fxfa/parser/cxfa_containerlayoutitem.cpp#newcode11 xfa/fxfa/parser/cxfa_containerlayoutitem.cpp:11: #include "xfa/fxfa/parser/cxfa_layoutpagemgr.h" alphabetical order
4 years, 4 months ago (2016-08-03 19:06:55 UTC) #7
dsinclair
https://codereview.chromium.org/2209823002/diff/40001/xfa/fxfa/parser/cxfa_containerlayoutitem.cpp File xfa/fxfa/parser/cxfa_containerlayoutitem.cpp (right): https://codereview.chromium.org/2209823002/diff/40001/xfa/fxfa/parser/cxfa_containerlayoutitem.cpp#newcode11 xfa/fxfa/parser/cxfa_containerlayoutitem.cpp:11: #include "xfa/fxfa/parser/cxfa_layoutpagemgr.h" On 2016/08/03 19:06:55, Lei Zhang wrote: > ...
4 years, 4 months ago (2016-08-03 19:47:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209823002/60001
4 years, 4 months ago (2016-08-03 19:48:10 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 19:58:57 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/8d0cc67cdf3ef45ee7268d3e00a21c0a9984...

Powered by Google App Engine
This is Rietveld 408576698