Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/offline_pages/background/request_coordinator_event_logger_unittest.cc

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_event_logger_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_event_logger_unittest.cc b/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
index a8189a95c71e29ade4cdd305dbeb0fd46ab626f3..b04e6b6e8d8c1625e9bba801994536c4cb54c856 100644
--- a/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
@@ -11,11 +11,17 @@ namespace offline_pages {
namespace {
const char kNamespace[] = "last_n";
-const char kStatus[] = "pending";
+const Offliner::RequestStatus kStatus = Offliner::SAVED;
const int64_t kId = 1234;
-const char kLogString[] =
+const RequestQueue::UpdateRequestResult kUpdateResult =
+ RequestQueue::UpdateRequestResult::STORE_FAILURE;
+
+const char kStatusLogString[] =
"Save page request for ID: 1234 and namespace: "
- "last_n has been updated with status pending";
+ "last_n has been updated with status SAVED";
+const char kUpdateResultLogString[] =
+ "Updating queued request for namespace: last_n failed with result: "
+ "STORE_FAILURE";
const int kTimeLength = 21;
} // namespace
@@ -26,10 +32,12 @@ TEST(RequestCoordinatorEventLoggerTest, RecordsWhenLoggingIsOn) {
logger.SetIsLogging(true);
logger.RecordSavePageRequestUpdated(kNamespace, kStatus, kId);
+ logger.RecordUpdateRequestFailed(kNamespace, kUpdateResult);
logger.GetLogs(&log);
- EXPECT_EQ(1u, log.size());
- EXPECT_EQ(std::string(kLogString), log[0].substr(kTimeLength));
+ EXPECT_EQ(2u, log.size());
+ EXPECT_EQ(std::string(kUpdateResultLogString), log[0].substr(kTimeLength));
+ EXPECT_EQ(std::string(kStatusLogString), log[1].substr(kTimeLength));
}
TEST(RequestCoordinatorEventLoggerTest, RecordsWhenLoggingIsOff) {

Powered by Google App Engine
This is Rietveld 408576698