components/offline_pages/background/request_coordinator_event_logger.h - Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator_event_logger.h

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot complaint for no return value on string mapping methods Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/background/request_coordinator.cc ('K') | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_coordinator_event_logger.cc » ('j') | components/offline_pages/background/request_queue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator_event_logger.h

diff --git a/components/offline_pages/background/request_coordinator_event_logger.h b/components/offline_pages/background/request_coordinator_event_logger.h

index 0e0476435898582911c543ec1930a06ba0c04744..483ee75eb05aca225b35be5ff0a92445cc987475 100644

--- a/components/offline_pages/background/request_coordinator_event_logger.h

+++ b/components/offline_pages/background/request_coordinator_event_logger.h

@@ -6,6 +6,7 @@

#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_EVENT_LOGGER_H_

#include <stdint.h>

+#include <string>

#include "components/offline_pages/offline_event_logger.h"

@@ -18,6 +19,9 @@ class RequestCoordinatorEventLogger : public OfflineEventLogger {

void RecordSavePageRequestUpdated(const std::string& name_space,

const std::string& new_status,

int64_t request_id);

+ void RecordUpdateRequestFailed(const std::string& name_space,

+ const std::string& result);

};

} // namespace offline_pages